From: W.C.A. Wijngaards Date: Wed, 20 Nov 2019 11:56:39 +0000 (+0100) Subject: - Fix Local Memory Leak in cachedb_init(), X-Git-Tag: release-1.9.6rc1~48 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2dcc7016ac6da9e57da91cc764734d11d766d8b0;p=thirdparty%2Funbound.git - Fix Local Memory Leak in cachedb_init(), reported by X41 D-Sec. --- diff --git a/cachedb/cachedb.c b/cachedb/cachedb.c index 92217db3d..d5cd8dc55 100644 --- a/cachedb/cachedb.c +++ b/cachedb/cachedb.c @@ -244,6 +244,8 @@ cachedb_init(struct module_env* env, int id) env->modinfo[id] = (void*)cachedb_env; if(!cachedb_apply_cfg(cachedb_env, env->cfg)) { log_err("cachedb: could not apply configuration settings."); + free(cachedb_env); + env->modinfo[id] = NULL; return 0; } /* see if a backend is selected */ @@ -252,6 +254,8 @@ cachedb_init(struct module_env* env, int id) if(!(*cachedb_env->backend->init)(env, cachedb_env)) { log_err("cachedb: could not init %s backend", cachedb_env->backend->name); + free(cachedb_env); + env->modinfo[id] = NULL; return 0; } cachedb_env->enabled = 1; diff --git a/doc/Changelog b/doc/Changelog index a4f6d873c..cda8f1df6 100644 --- a/doc/Changelog +++ b/doc/Changelog @@ -14,6 +14,8 @@ reported by X41 D-Sec. - Fix Config Injection in create_unbound_ad_servers.sh, reported by X41 D-Sec. + - Fix Local Memory Leak in cachedb_init(), + reported by X41 D-Sec. 19 November 2019: Wouter - Fix CVE-2019-18934, shell execution in ipsecmod.