From: Andrew Bartlett <abartlet@samba.org>
Date: Mon, 28 May 2018 22:40:56 +0000 (+1200)
Subject: samldb: Explain why the odd error code is expected.
X-Git-Tag: ldb-1.4.0~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2dedd49ca3041970ffe02f9adf69fbbb3cee7a4c;p=thirdparty%2Fsamba.git

samldb: Explain why the odd error code is expected.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
---

diff --git a/source4/dsdb/samdb/ldb_modules/samldb.c b/source4/dsdb/samdb/ldb_modules/samldb.c
index f6fe6185aa4..da11ee2180c 100644
--- a/source4/dsdb/samdb/ldb_modules/samldb.c
+++ b/source4/dsdb/samdb/ldb_modules/samldb.c
@@ -3929,6 +3929,10 @@ static int samldb_prim_group_users_check(struct samldb_ctx *ac)
 				       ldb_dn_get_linearized(res->msgs[0]->dn),
 				       res_users->count);
 
+		/*
+		 * Yes, this seems very wrong, but we have a test
+		 * for this exact error code in sam.py
+		 */
 		return LDB_ERR_ENTRY_ALREADY_EXISTS;
 	}