From: Eric Wong <e@80x24.org>
Date: Fri, 15 Nov 2024 02:59:31 +0000 (+0000)
Subject: view: reduce ops for <b> encasement
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2df76ea74d919a6655914660aff7f13a43497414;p=thirdparty%2Fpublic-inbox.git

view: reduce ops for <b> encasement

We can rely on print to concatenate its args and
reduce the amount of needless copies and string ops before the
print.
---

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 7ca85a859..ad2592530 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -272,13 +272,12 @@ sub emit_eml ($$) {
 	my $root_anchor = $ctx->{root_anchor} || '';
 	my $irt;
 	my $obfs_ibx = $ctx->{-obfs_ibx};
-	$subj = '(no subject)' if $subj eq '';
-	$subj = '<b>'.ascii_html($subj).'</b>';
+	$subj = $subj eq '' ? '(no subject)' : ascii_html($subj);
 	obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx;
 	$subj = "<u\nid=u>$subj</u>" if $root_anchor eq $id_m;
 	my $zfh = $ctx->{zfh} // die 'BUG: no {zfh}';
-	print $zfh "<a\nhref=#e", $id, "\nid=m", $id, '>*</a> ',
-		$subj, "\n", _th_index_lite($mid_raw, \$irt, $id, $ctx);
+	print $zfh "<a\nhref=#e", $id, "\nid=m", $id, '>*</a> <b>',
+		$subj, "</b>\n", _th_index_lite($mid_raw, \$irt, $id, $ctx);
 	my @tocc;
 	my $ds = delete $smsg->{ds}; # for v1 non-Xapian/SQLite users