From: TCY16 <tom@nlnetlabs.nl>
Date: Tue, 12 Apr 2022 11:55:12 +0000 (+0200)
Subject: remove non-const cast from ldns_edns_option *
X-Git-Tag: 1.8.2-rc.1~3^2~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2dfc33c;p=thirdparty%2Fldns.git

remove non-const cast from ldns_edns_option *
---

diff --git a/edns.c b/edns.c
index b1db5f03..bc40f226 100644
--- a/edns.c
+++ b/edns.c
@@ -266,7 +266,7 @@ ldns_edns_option_list_get_options_size(const ldns_edns_option_list *option_list)
 
 ldns_edns_option *
 ldns_edns_option_list_set_option(ldns_edns_option_list *option_list,
-	const ldns_edns_option *option, size_t index)
+	ldns_edns_option *option, size_t index)
 {
 	ldns_edns_option* old;
 
@@ -289,8 +289,7 @@ ldns_edns_option_list_set_option(ldns_edns_option_list *option_list,
 
 	option_list->_options_size += (ldns_edns_get_size(option) + 4);
 
-	/* overwrite the pointer of the old entry */
-	option_list->_options[index] = (ldns_edns_option*)option;
+	option_list->_options[index] = option;
 	return old;
 }
 
diff --git a/ldns/edns.h b/ldns/edns.h
index a1bfa91f..272351d0 100644
--- a/ldns/edns.h
+++ b/ldns/edns.h
@@ -245,7 +245,7 @@ size_t ldns_edns_option_list_get_options_size(const ldns_edns_option_list *optio
  * \return the EDNS option previously located at the index
  */
 ldns_edns_option * ldns_edns_option_list_set_option(ldns_edns_option_list *options_list,
-	const ldns_edns_option *option, size_t index);
+	ldns_edns_option *option, size_t index);
 
 /**
  * adds an EDNS option at the end of the list of options.