From: Eduardo San Martin Morote <posva13@gmail.com>
Date: Thu, 15 Jul 2021 16:15:50 +0000 (+0200)
Subject: feat(hmr): remove old getters and actionss
X-Git-Tag: v2.0.0-rc.0~66
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e19cceaa2664e4c5e61da9f220f3d036d729afc;p=thirdparty%2Fvuejs%2Fpinia.git

feat(hmr): remove old getters and actionss
---

diff --git a/playground/src/App.vue b/playground/src/App.vue
index 6af39d74..9035e521 100644
--- a/playground/src/App.vue
+++ b/playground/src/App.vue
@@ -15,9 +15,7 @@
 </template>
 
 <script lang="ts" setup>
-import { ref } from 'vue'
 import { useRouter } from 'vue-router'
-import { useCounter } from './stores/counter'
 
 const router = useRouter()
 
diff --git a/src/store.ts b/src/store.ts
index 74811796..89c8585a 100644
--- a/src/store.ts
+++ b/src/store.ts
@@ -473,7 +473,7 @@ function createSetupStore<
 
       pinia.state.value[$id] = toRef(newStore._hmrPayload, 'hotState')
 
-      // remove deleted keys
+      // remove deleted state properties
       Object.keys(store.$state).forEach((stateKey) => {
         if (!(stateKey in newStore.$state)) {
           // @ts-expect-error
@@ -494,7 +494,6 @@ function createSetupStore<
 
       for (const getterName in newStore._hmrPayload.getters) {
         const getter: _Method = newStore._hmrPayload.getters[getterName]
-
         // @ts-expect-error
         store[getterName] =
           // ---
@@ -507,7 +506,30 @@ function createSetupStore<
             : getter
       }
 
-      // TODO: remove old actions and getters
+      // remove deleted getters
+      console.log('remove', store._hmrPayload)
+      Object.keys(store._hmrPayload.getters).forEach((key) => {
+        console.log('checking for', key)
+        if (!(key in newStore._hmrPayload.getters)) {
+          console.log('deleting')
+          // @ts-expect-error
+          delete store[key]
+        }
+      })
+
+      // remove old actions
+      Object.keys(store._hmrPayload.actions).forEach((key) => {
+        console.log('checking for', key)
+        if (!(key in newStore._hmrPayload.actions)) {
+          console.log('deleting')
+          // @ts-expect-error
+          delete store[key]
+        }
+      })
+
+      // update the values used in devtools and to allow deleting new properties later on
+      store._hmrPayload = newStore._hmrPayload
+      store._getters = newStore._getters
     })
 
     const nonEnumerable = {