From: Joseph Sutton Date: Thu, 27 Jul 2023 23:53:57 +0000 (+1200) Subject: s4:rpc_server/backupkey: Fix leaks X-Git-Tag: tevent-0.16.0~1098 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e1adcfc2db533e951ce59f794b469bc867e7d10;p=thirdparty%2Fsamba.git s4:rpc_server/backupkey: Fix leaks Allocate these objects on a shorter-lived memory context. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/source4/rpc_server/backupkey/dcesrv_backupkey.c b/source4/rpc_server/backupkey/dcesrv_backupkey.c index 1c87d3ba64c..d2c504ffa7d 100644 --- a/source4/rpc_server/backupkey/dcesrv_backupkey.c +++ b/source4/rpc_server/backupkey/dcesrv_backupkey.c @@ -100,9 +100,9 @@ static NTSTATUS set_lsa_secret(TALLOC_CTX *mem_ctx, return NT_STATUS_NO_MEMORY; } - ret = ldb_search(ldb, mem_ctx, &res, system_dn, LDB_SCOPE_SUBTREE, attrs, + ret = ldb_search(ldb, frame, &res, system_dn, LDB_SCOPE_SUBTREE, attrs, "(&(cn=%s)(objectclass=secret))", - ldb_binary_encode_string(mem_ctx, name2)); + ldb_binary_encode_string(frame, name2)); if (ret != LDB_SUCCESS || res->count != 0 ) { DEBUG(2, ("Secret %s already exists !\n", name2)); @@ -202,7 +202,7 @@ static NTSTATUS get_lsa_secret(TALLOC_CTX *mem_ctx, return NT_STATUS_NO_MEMORY; } - ret = ldb_search(ldb, mem_ctx, &res, system_dn, LDB_SCOPE_SUBTREE, attrs, + ret = ldb_search(ldb, tmp_mem, &res, system_dn, LDB_SCOPE_SUBTREE, attrs, "(&(cn=%s Secret)(objectclass=secret))", ldb_binary_encode_string(tmp_mem, name));