From: Daniel Axtens <dja@axtens.net>
Date: Sat, 1 Jul 2017 04:06:51 +0000 (+1000)
Subject: Make browser tests work again
X-Git-Tag: v2.0.0~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e1fb5368bb4af97fdad175fea13a41f24b36ee0;p=thirdparty%2Fpatchwork.git

Make browser tests work again

Save us the embarassement of releasing v2 with broken tests.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Reviewed-by: Stephen Finucane <stephen@that.guru>
---

diff --git a/patchwork/tests/browser.py b/patchwork/tests/browser.py
index 38413d51..3ea3266b 100644
--- a/patchwork/tests/browser.py
+++ b/patchwork/tests/browser.py
@@ -30,6 +30,7 @@ from selenium.common.exceptions import (
     TimeoutException)
 from selenium import webdriver
 from selenium.webdriver.support.ui import WebDriverWait
+from selenium.webdriver.chrome.options import Options
 
 
 class Wait(WebDriverWait):
@@ -110,8 +111,14 @@ class SeleniumTestCase(StaticLiveServerTestCase):
         if self.browser == 'firefox':
             self.selenium = webdriver.Firefox()
         if self.browser == 'chrome':
+            chrome_options = Options()
+            # chrome's aggressive sandboxing doesn't work well with
+            # docker so disable the sandbox. We're only looking at our
+            # own site so it should be safe enough
+            chrome_options.add_argument("--no-sandbox")
             self.selenium = webdriver.Chrome(
-                service_args=['--verbose', '--log-path=selenium.log']
+                service_args=['--verbose', '--log-path=selenium.log'],
+                chrome_options=chrome_options
             )
 
         mkdir(self._SCREENSHOT_DIR)