From: Michael Tremer <michael.tremer@ipfire.org>
Date: Fri, 31 Oct 2025 17:42:53 +0000 (+0000)
Subject: graphs: disk: Add a comment about discards
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e281d7134433258ce7ed6f48ac054f049369a56;p=telemetry.git

graphs: disk: Add a comment about discards

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/daemon/graphs/disk.c b/src/daemon/graphs/disk.c
index a9e94fe..7a15fbe 100644
--- a/src/daemon/graphs/disk.c
+++ b/src/daemon/graphs/disk.c
@@ -43,7 +43,9 @@ static int disk_io_render(td_ctx* ctx, td_graph* graph,
 	// Draw the temperature
 	DRAW_IO_BYTES_FROM_SECTORS(args, object, "read_sectors", "write_sectors");
 
-	// XXX TODO Add discarded bytes
+	// I tried to add the discarded bytes here, but it has been a surprisingly high
+	// amount of discards. There have been massive spikes (I assume from fstrim) and
+	// generally enough data to constantly draw over the graph. So it wasn't usable.
 
 	return 0;
 }