From: Matthew Wilcox (Oracle) Date: Wed, 8 Nov 2023 20:46:04 +0000 (+0000) Subject: smb: do not test the return value of folio_start_writeback() X-Git-Tag: v6.6.23~142 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e411c57562f81144431caa45ba33c7d6da86037;p=thirdparty%2Fkernel%2Fstable.git smb: do not test the return value of folio_start_writeback() [ Upstream commit a9540e35624d1475f47dbf6353eed8b99936d36e ] In preparation for removing the return value entirely, stop testing it in smb. Link: https://lkml.kernel.org/r/20231108204605.745109-4-willy@infradead.org Signed-off-by: Matthew Wilcox (Oracle) Cc: David Howells Cc: Steve French Signed-off-by: Andrew Morton Stable-dep-of: f3dc1bdb6b0b ("cifs: Fix writeback data corruption") Signed-off-by: Sasha Levin --- diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index 4cbb5487bd8d0..043bee4020a91 100644 --- a/fs/smb/client/file.c +++ b/fs/smb/client/file.c @@ -2709,8 +2709,7 @@ static void cifs_extend_writeback(struct address_space *mapping, */ if (!folio_clear_dirty_for_io(folio)) WARN_ON(1); - if (folio_start_writeback(folio)) - WARN_ON(1); + folio_start_writeback(folio); *_count -= folio_nr_pages(folio); folio_unlock(folio); @@ -2745,8 +2744,7 @@ static ssize_t cifs_write_back_from_locked_folio(struct address_space *mapping, int rc; /* The folio should be locked, dirty and not undergoing writeback. */ - if (folio_start_writeback(folio)) - WARN_ON(1); + folio_start_writeback(folio); count -= folio_nr_pages(folio); len = folio_size(folio);