From: NeilBrown <neilb@suse.de>
Date: Thu, 28 Nov 2013 02:30:23 +0000 (+1100)
Subject: Incremental: remove test that can never succeed.
X-Git-Tag: mdadm-3.3.1~95
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e44767fc2e202da87f51d4c25b83791cdf40e03;p=thirdparty%2Fmdadm.git

Incremental: remove test that can never succeed.

Incremental_container never returns 1, so this test is pointless.
It is a holdover from when we called "Incremental()" rather than
"Incremental_container()" at this point.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/Incremental.c b/Incremental.c
index 1bb3638f..68080957 100644
--- a/Incremental.c
+++ b/Incremental.c
@@ -480,11 +480,6 @@ int Incremental(char *devname, struct context *c,
 		if (!rv)
 			rv = Incremental_container(st, chosen_name, c, NULL);
 		map_unlock(&map);
-		if (rv == 1)
-			/* Don't fail the whole -I if a subarray didn't
-			 * have enough devices to start yet
-			 */
-			rv = 0;
 		/* after spare is added, ping monitor for external metadata
 		 * so that it can eg. try to rebuild degraded array */
 		if (st->ss->external)