From: Alan Modra <amodra@gmail.com>
Date: Fri, 3 Feb 2017 08:48:37 +0000 (+1030)
Subject: [GOLD] PowerPC64 TOC indirect to TOC relative segfault
X-Git-Tag: users/ARM/embedded-binutils-2_28-branch-2017q1~21
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e5c40b65afa4c29b60e795bb8ba2cefddc2d6c6;p=thirdparty%2Fbinutils-gdb.git

[GOLD] PowerPC64 TOC indirect to TOC relative segfault

	* powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
	when no .toc section exists.
---

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 1be238cab67..f36dae744ee 100644
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,8 @@
+2017-02-03  Alan Modra  <amodra@gmail.com>
+
+	* powerpc.cc (Powerpc_relobj::make_toc_relative): Don't crash
+	when no .toc section exists.
+
 2017-01-23  Vladimir Radosavljevic  <Vladimir.Radosavljevic@imgtec.com>
 
 	* mips.cc (Mips_output_data_plt::rel_plt): Remove const from return
diff --git a/gold/powerpc.cc b/gold/powerpc.cc
index a67c33618bd..4abfcec16d6 100644
--- a/gold/powerpc.cc
+++ b/gold/powerpc.cc
@@ -1986,6 +1986,12 @@ Powerpc_relobj<size, big_endian>::make_toc_relative(
   if (size != 64)
     return false;
 
+  // With -mcmodel=medium code it is quite possible to have
+  // toc-relative relocs referring to objects outside the TOC.
+  // Don't try to look at a non-existent TOC.
+  if (this->toc_shndx() == 0)
+    return false;
+
   // Convert VALUE back to an address by adding got_base (see below),
   // then to an offset in the TOC by subtracting the TOC output
   // section address and the TOC output offset.  Since this TOC output