From: Dr. David von Oheimb Date: Fri, 12 Nov 2021 11:14:45 +0000 (+0100) Subject: check-format.pl: Fix report on constant on LHS of comparison or assignment X-Git-Tag: openssl-3.2.0-alpha1~3143 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e6afe1079c6993868c5d8a813605d16980e8e10;p=thirdparty%2Fopenssl.git check-format.pl: Fix report on constant on LHS of comparison or assignment Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/17396) --- diff --git a/util/check-format.pl b/util/check-format.pl index 62471e3c680..09bd6b62707 100755 --- a/util/check-format.pl +++ b/util/check-format.pl @@ -858,7 +858,7 @@ while (<>) { # loop over all lines of all input files report("single-letter name '$2'") if (m/(^|.*\W)([IO])(\W.*|$)/); # single-letter name 'I' or 'O' # maybe re-add 'l'? # constant on LHS of comparison or assignment, e.g., NULL != x or 'a' < c, but not a + 1 == b - report("constant on LHS of '$2'") + report("constant on LHS of '$3'") if (m/(['"]|([\+\-\*\/\/%\&\|\^<>]\s*)?\W[0-9]+L?|NULL)\s*([\!<>=]=|[<=>][^<>])/ && $2 eq ""); # TODO report #if 0 and #if 1