From: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu, 8 Apr 2021 12:57:55 +0000 (+0100)
Subject: meson: remove obsolete comment about stack frame size
X-Git-Tag: v7.3.0-rc1~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e85a83abee2982a7791e9b5d912af3799032bf6;p=thirdparty%2Flibvirt.git

meson: remove obsolete comment about stack frame size

The virStrerror function no longer exists in libvirt so is not a
constraint. At the current stack limit of 4k, and default Linux
stack size of 8 MB, we have a recursion limit of 2048 in the
absolute worst case, and much higher in common case. Even with
smaller stack sizes, we're going to be fine as we don't deeply
recurse in code.

Thus it is not worth spending effort to optimize below our current
4k worst case limit. Removing the comment will stop encouraging
people to spend time on this in future.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/meson.build b/meson.build
index 5d49ca6489..dec46c4971 100644
--- a/meson.build
+++ b/meson.build
@@ -409,9 +409,6 @@ cc_flags += [
   # but need to rewrite various areas of code first
   '-Wno-format-truncation',
 
-  # This should be < 256 really. Currently we're down to 4096,
-  # but using 1024 bytes sized buffers (mostly for virStrerror)
-  # stops us from going down further
   '-Wframe-larger-than=4096',
 
   # extra special flags