From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 21 Oct 2024 17:11:03 +0000 (-0400)
Subject: add more errors
X-Git-Tag: release_3_2_7~177
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e867548478cf52cf754cc0b7aad485a0f52ac30;p=thirdparty%2Ffreeradius-server.git

add more errors
---

diff --git a/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c b/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
index 9fe8a191306..064d2cd8199 100644
--- a/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
+++ b/src/modules/rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c
@@ -115,15 +115,17 @@ static int sql_check_error(rlm_sql_handle_t *handle, rlm_sql_config_t *config)
 {
 	char errbuff[512];
 
-	if (sql_prints_error(errbuff, sizeof(errbuff), handle, config) < 0) goto unknown;
+	if (sql_prints_error(errbuff, sizeof(errbuff), handle, config) < 0) {
+		ERROR("rlm_sql_oracle: OCI_SERVER_NORMAL");
+		return -1;
+	}
 
 	if (strstr(errbuff, "ORA-03113") || strstr(errbuff, "ORA-03114")) {
 		ERROR("rlm_sql_oracle: OCI_SERVER_NOT_CONNECTED");
 		return RLM_SQL_RECONNECT;
 	}
 
-unknown:
-	ERROR("rlm_sql_oracle: OCI_SERVER_NORMAL");
+	ERROR("rlm_sql_oracle: error %s", errbuff);
 	return -1;
 }
 
@@ -437,6 +439,7 @@ static sql_rcode_t sql_finish_query(UNUSED rlm_sql_handle_t *handle, UNUSED rlm_
 
 	if (OCIStmtRelease(conn->query, conn->error, NULL, 0, OCI_DEFAULT) != OCI_SUCCESS ) {
 		ERROR("OCI release failed in sql_finish_query");
+		(void) sql_check_error(handle, config);
 		return RLM_SQL_ERROR;
 	}