From: Jouni Malinen <j@w1.fi>
Date: Sat, 6 Aug 2011 18:16:31 +0000 (+0300)
Subject: random: Check fwrite return value to avoid warnings
X-Git-Tag: hostap-1-bp~278
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e923102171e5dacd2a1affda70d506a9ef433c7;p=thirdparty%2Fhostap.git

random: Check fwrite return value to avoid warnings

Some compilers complain about fwrite calls if the return value is
not checked, so check the value even if it does not really make
much of a difference in this particular case.
---

diff --git a/src/crypto/random.c b/src/crypto/random.c
index 7f5c08a6d..5b15354b7 100644
--- a/src/crypto/random.c
+++ b/src/crypto/random.c
@@ -354,6 +354,7 @@ static void random_write_entropy(void)
 	char buf[RANDOM_ENTROPY_SIZE];
 	FILE *f;
 	u8 opr;
+	int fail = 0;
 
 	if (!random_entropy_file)
 		return;
@@ -369,9 +370,15 @@ static void random_write_entropy(void)
 	}
 
 	opr = own_pool_ready > 0xff ? 0xff : own_pool_ready;
-	fwrite(&opr, 1, 1, f);
-	fwrite(buf, RANDOM_ENTROPY_SIZE, 1, f);
+	if (fwrite(&opr, 1, 1, f) != 1 ||
+	    fwrite(buf, RANDOM_ENTROPY_SIZE, 1, f) != 1)
+		fail = 1;
 	fclose(f);
+	if (fail) {
+		wpa_printf(MSG_ERROR, "random: Could not entropy data to %s",
+			   random_entropy_file);
+		return;
+	}
 
 	wpa_printf(MSG_DEBUG, "random: Updated entropy file %s "
 		   "(own_pool_ready=%u)",