From: mkanat%bugzilla.org <>
Date: Wed, 24 Dec 2008 19:08:58 +0000 (+0000)
Subject: Bug 347707: Changing parameters could silently fail because we weren't correctly
X-Git-Tag: bugzilla-3.2.1~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2e96079cb82db756520033f0562708529ded43a1;p=thirdparty%2Fbugzilla.git

Bug 347707: Changing parameters could silently fail because we weren't correctly
 checking the return code from "rename"
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=justdave, a=mkanat
---

diff --git a/Bugzilla/Config.pm b/Bugzilla/Config.pm
index 428c13fe51..619eb05a88 100644
--- a/Bugzilla/Config.pm
+++ b/Bugzilla/Config.pm
@@ -279,7 +279,7 @@ sub write_params {
     close $fh;
 
     rename $tmpname, $param_file
-      || die "Can't rename $tmpname to $param_file: $!";
+      or die "Can't rename $tmpname to $param_file: $!";
 
     ChmodDataFile($param_file, 0666);