From: Michal Privoznik Date: Thu, 10 Jan 2019 12:53:33 +0000 (+0100) Subject: qemu: Don't enable seclabel remembering for session mode X-Git-Tag: v5.0.0-rc1~8 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2ebcff3a74931e6927c3afa7c48c9b0fecf0db4b;p=thirdparty%2Flibvirt.git qemu: Don't enable seclabel remembering for session mode The session daemon is unable to set XATTRs in 'trusted' namespace because it doesn't run as privileged process. Therefore, when creating the default qemu config enable rememberOwner only when running as privileged process. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 3718ca6c22..20952e9607 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -145,7 +145,7 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) cfg->group = (gid_t)-1; } cfg->dynamicOwnership = privileged; - cfg->rememberOwner = true; + cfg->rememberOwner = privileged; cfg->cgroupControllers = -1; /* -1 == auto-detect */