From: Tilghman Lesher Date: Wed, 30 Jun 2010 01:07:57 +0000 (+0000) Subject: Merged revisions 273144 via svnmerge from X-Git-Tag: 1.6.2.11-rc1~68 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2ec5c7c8c6702298dd586b64248a6ed0017b49e0;p=thirdparty%2Fasterisk.git Merged revisions 273144 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ........ r273144 | tilghman | 2010-06-29 20:07:02 -0500 (Tue, 29 Jun 2010) | 8 lines Permission checking for the system application is backwards. (closes issue #17550) Reported by: kenner Patches: manager.c.diff uploaded by kenner (license 1040) Tested by: kenner ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@273145 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/main/manager.c b/main/manager.c index faa6538e42..5bbeec0fca 100644 --- a/main/manager.c +++ b/main/manager.c @@ -2523,7 +2523,7 @@ static int action_originate(struct mansession *s, const struct message *m) /* To run the System application (or anything else that goes to shell), you must have the additional System privilege */ if (!(s->session->writeperm & EVENT_FLAG_SYSTEM) && ( - strcasestr(app, "system") == 0 || /* System(rm -rf /) + strcasestr(app, "system") || /* System(rm -rf /) TrySystem(rm -rf /) */ strcasestr(app, "exec") || /* Exec(System(rm -rf /)) TryExec(System(rm -rf /)) */