From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Mon, 26 Mar 2018 21:03:28 +0000 (+0200)
Subject: start: always make us dumpable
X-Git-Tag: lxc-2.0.10~180
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2efc4ab7d1f94a7a43a407ba322738fe41ffa513;p=thirdparty%2Flxc.git

start: always make us dumpable

Otherwise lxc.hook.mount hooks that try to inspect /proc/<pid>/*
will fail.

Cc: Jonathan Calmels <jcalmels@nvidia.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/start.c b/src/lxc/start.c
index a92afe6c1..17dca1806 100644
--- a/src/lxc/start.c
+++ b/src/lxc/start.c
@@ -1142,11 +1142,9 @@ static int do_start(void *data)
 		if (ret < 0 && (handler->am_root || errno != EPERM))
 			goto out_warn_father;
 
-		if (!handler->am_root) {
-			ret = prctl(PR_SET_DUMPABLE, 1, 0, 0, 0);
-			if (ret < 0)
-				goto out_warn_father;
-		}
+		ret = prctl(PR_SET_DUMPABLE, 1, 0, 0, 0);
+		if (ret < 0)
+			goto out_warn_father;
 
 		/* set{g,u}id() clears deathsignal */
 		ret = lxc_set_death_signal(SIGKILL);