From: Volker Lendecke <vl@samba.org>
Date: Sun, 22 Mar 2026 16:14:49 +0000 (+0100)
Subject: smbd: Make smb_set_file_unix_basic() slightly easier to read
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f1120304c5c9e817bf910524909f59e9731407e;p=thirdparty%2Fsamba.git

smbd: Make smb_set_file_unix_basic() slightly easier to read

Having set_owner/set_grp on the same side of the "!=" makes it easier
for the eye to parse.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>

Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Fri Jun 26 11:45:20 UTC 2026 on atb-devel-224
---

diff --git a/source3/smbd/smb1_trans2.c b/source3/smbd/smb1_trans2.c
index f86a7b79035..02223e6b36e 100644
--- a/source3/smbd/smb1_trans2.c
+++ b/source3/smbd/smb1_trans2.c
@@ -4016,7 +4016,7 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 	 */
 
 	if ((set_owner != (uid_t)SMB_UID_NO_CHANGE) &&
-	    (sbuf.st_ex_uid != set_owner)) {
+	    (set_owner != sbuf.st_ex_uid)) {
 		int ret;
 
 		DBG_DEBUG("SMB_SET_FILE_UNIX_BASIC "
@@ -4049,7 +4049,7 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 	 */
 
 	if ((set_grp != (uid_t)SMB_GID_NO_CHANGE) &&
-	    (sbuf.st_ex_gid != set_grp)) {
+	    (set_grp != sbuf.st_ex_gid)) {
 		int ret;
 
 		DBG_DEBUG("SMB_SET_FILE_UNIX_BASIC "