From: Aram Sargsyan <aram@isc.org>
Date: Mon, 5 Sep 2022 14:42:32 +0000 (+0000)
Subject: Fix isc_nm_listentlsdns() error path bug
X-Git-Tag: v9.19.5~15^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f11e48f0d0317ec92aac421197a8b148da6103b;p=thirdparty%2Fbind9.git

Fix isc_nm_listentlsdns() error path bug

The isc_nm_listentlsdns() function erroneously calls
isc__nm_tcpdns_stoplistening() instead of isc__nm_tlsdns_stoplistening()
when something goes wrong, which can cause an assertion failure.
---

diff --git a/lib/isc/netmgr/tlsdns.c b/lib/isc/netmgr/tlsdns.c
index a4ae9755e6e..3ad86a39793 100644
--- a/lib/isc/netmgr/tlsdns.c
+++ b/lib/isc/netmgr/tlsdns.c
@@ -542,7 +542,7 @@ isc_nm_listentlsdns(isc_nm_t *mgr, uint32_t workers, isc_sockaddr_t *iface,
 
 	if (result != ISC_R_SUCCESS) {
 		atomic_store(&sock->active, false);
-		isc__nm_tcpdns_stoplistening(sock);
+		isc__nm_tlsdns_stoplistening(sock);
 		isc_nmsocket_close(&sock);
 
 		return (result);