From: Jo Sutton <josutton@catalyst.net.nz>
Date: Thu, 14 Mar 2024 02:14:55 +0000 (+1300)
Subject: s4:auth: Allocate strings on shorter‐lived memory context
X-Git-Tag: tdb-1.4.11~1392
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f25c23b7bb4f935e3b9ebf77fa1309de1e2df48;p=thirdparty%2Fsamba.git

s4:auth: Allocate strings on shorter‐lived memory context

Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/auth/kerberos/kerberos_util.c b/source4/auth/kerberos/kerberos_util.c
index d022b0dda1b..cc1bfc7ca16 100644
--- a/source4/auth/kerberos/kerberos_util.c
+++ b/source4/auth/kerberos/kerberos_util.c
@@ -602,7 +602,7 @@ krb5_error_code smb_krb5_remove_obsolete_keytab_entries(TALLOC_CTX *mem_ctx,
 	default:
 		*error_string = talloc_asprintf(mem_ctx,
 						"failed to open keytab for read of old entries: %s\n",
-						smb_get_krb5_error_message(context, code, mem_ctx));
+						smb_get_krb5_error_message(context, code, tmp_ctx));
 		goto done;
 	}
 
@@ -711,7 +711,7 @@ krb5_error_code smb_krb5_remove_obsolete_keytab_entries(TALLOC_CTX *mem_ctx,
 						"failed in deleting old entries for principal: %s\n",
 						smb_get_krb5_error_message(context,
 									   code,
-									   mem_ctx));
+									   tmp_ctx));
 		goto done;
 	}
 
@@ -763,7 +763,7 @@ krb5_error_code smb_krb5_is_exact_entry_in_keytab(TALLOC_CTX *mem_ctx,
 	default:
 		*error_string = talloc_asprintf(mem_ctx,
 						"failed to open keytab for read of existing entries: %s\n",
-						smb_get_krb5_error_message(context, code, mem_ctx));
+						smb_get_krb5_error_message(context, code, tmp_ctx));
 		goto done;
 	}
 
@@ -814,7 +814,7 @@ krb5_error_code smb_krb5_is_exact_entry_in_keytab(TALLOC_CTX *mem_ctx,
 						"failed in checking old entries for principal: %s\n",
 						smb_get_krb5_error_message(context,
 									   code,
-									   mem_ctx));
+									   tmp_ctx));
 		goto done;
 	}