From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 23 Aug 2022 14:19:31 +0000 (+0200)
Subject: do sqlite migration without temp table
X-Git-Tag: rec-4.8.0-alpha1~39^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f49974d42e40924fc4950d1201a5f2fdefe674d;p=thirdparty%2Fpdns.git

do sqlite migration without temp table
---

diff --git a/modules/gsqlite3backend/4.3.1_to_4.7.0_schema.sqlite3.sql b/modules/gsqlite3backend/4.3.1_to_4.7.0_schema.sqlite3.sql
index 0d9c4e837d..e6774d52ea 100644
--- a/modules/gsqlite3backend/4.3.1_to_4.7.0_schema.sqlite3.sql
+++ b/modules/gsqlite3backend/4.3.1_to_4.7.0_schema.sqlite3.sql
@@ -3,23 +3,9 @@
 PRAGMA foreign_keys = 0;
 
 BEGIN TRANSACTION;
-  CREATE TABLE domains_temp (
-    id                    INTEGER PRIMARY KEY,
-    name                  VARCHAR(255) NOT NULL COLLATE NOCASE,
-    master                VARCHAR(128) DEFAULT NULL,
-    last_check            INTEGER DEFAULT NULL,
-    type                  VARCHAR(8) NOT NULL,
-    notified_serial       INTEGER DEFAULT NULL,
-    account               VARCHAR(40) DEFAULT NULL,
-    options               VARCHAR(65535) DEFAULT NULL,
-    catalog               VARCHAR(255) DEFAULT NULL
-  );
+  ALTER TABLE domains ADD options VARCHAR(65535) DEFAULT NULL;
+  ALTER TABLE domains ADD catalog VARCHAR(255) DEFAULT NULL;
 
-  INSERT INTO domains_temp SELECT id,name,master,last_check,type,notified_serial,NULL,NULL,account FROM domains;
-  DROP TABLE domains;
-  ALTER TABLE domains_temp RENAME TO domains;
-
-  CREATE UNIQUE INDEX name_index ON domains(name);
   CREATE INDEX catalog_idx ON domains(catalog);
 COMMIT;