From: Russell Bryant <russell@russellbryant.com>
Date: Sat, 24 Sep 2005 21:19:42 +0000 (+0000)
Subject: Fix CLI memory leak (issue #5035)
X-Git-Tag: 1.0.11.1~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f5ced421e6d6f182d01a8393ceb681dea8af01b;p=thirdparty%2Fasterisk.git

Fix CLI memory leak (issue #5035)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/v1-0@6636 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/cli.c b/cli.c
index d6100b84aa..11edf1faf1 100755
--- a/cli.c
+++ b/cli.c
@@ -1004,14 +1004,15 @@ int ast_cli_generatornummatches(char *text, char *word)
 	int matches = 0, i = 0;
 	char *buf = NULL, *oldbuf = NULL;
 
-	while ( (buf = ast_cli_generator(text, word, i)) ) {
-		if (++i > 1 && strcmp(buf,oldbuf) == 0)  {
-				continue;
-		}
+	while ( (buf = ast_cli_generator(text, word, i++)) ) {
+		if (!oldbuf || strcmp(buf,oldbuf))
+			matches++;
+		if (oldbuf)
+			free(oldbuf);
 		oldbuf = buf;
-		matches++;
 	}
-
+	if (oldbuf)
+		free(oldbuf);
 	return matches;
 }