From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 20 Jun 2016 17:37:45 +0000 (-0400)
Subject: Patch from dgoulet: fix a base16 problem that manifested w stem
X-Git-Tag: tor-0.2.9.1-alpha~130
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f75b34dcede23dad8835a941539935e82cf7988;p=thirdparty%2Ftor.git

Patch from dgoulet: fix a base16 problem that manifested w stem
---

diff --git a/src/or/control.c b/src/or/control.c
index f956307c0e..6e5dcf62e6 100644
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -1264,7 +1264,7 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
     password_len = i/2;
     password = tor_malloc(password_len + 1);
     if (base16_decode(password, password_len+1, body, i)
-                      != (int) (password_len+1)) {
+                      != (int) password_len) {
       connection_write_str_to_buf(
             "551 Invalid hexadecimal encoding.  Maybe you tried a plain text "
             "password?  If so, the standard requires that you put it in "