From: William Lallemand <wlallemand@haproxy.com>
Date: Tue, 29 Apr 2025 09:29:52 +0000 (+0200)
Subject: BUG/MINOR: acme: does not try to unlock after a failed trylock
X-Git-Tag: v3.2-dev13~50
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f7f65e159439a418ee842f3fdff32108df29bbb;p=thirdparty%2Fhaproxy.git

BUG/MINOR: acme: does not try to unlock after a failed trylock

Return after a failed trylock in acme_update_certificate() instead of
jumping to the error label which does an unlock.
---

diff --git a/src/acme.c b/src/acme.c
index 13241a745..45d701409 100644
--- a/src/acme.c
+++ b/src/acme.c
@@ -706,8 +706,7 @@ int acme_update_certificate(struct task *task, struct acme_ctx *ctx, char **errm
 
 	if (HA_SPIN_TRYLOCK(CKCH_LOCK, &ckch_lock)) {
 		memprintf(errmsg, "couldn't get the certificate lock!");
-		goto error;
-
+		return ret;
 	}
 
 	if ((old_ckchs = ckchs_lookup(new_ckchs->path)) == NULL) {