From: Andrew Bartlett <abartlet@samba.org>
Date: Fri, 16 Aug 2019 02:05:38 +0000 (+1200)
Subject: s3-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()
X-Git-Tag: tevent-0.10.1~265
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2f827bec8ca831fb486c8ebedc6b89b7f1cb99e2;p=thirdparty%2Fsamba.git

s3-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index 08bce367bf0..671300676ff 100644
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -1369,14 +1369,16 @@ NTSTATUS _netr_ServerPasswordSet2(struct pipes_struct *p,
 	SIVAL(password_buf.data, 512, r->in.new_password->length);
 
 	if (creds->negotiate_flags & NETLOGON_NEG_SUPPORTS_AES) {
-		netlogon_creds_aes_decrypt(creds, password_buf.data, 516);
+		status = netlogon_creds_aes_decrypt(creds,
+						    password_buf.data,
+						    516);
 	} else {
 		status = netlogon_creds_arcfour_crypt(creds,
 						      password_buf.data,
 						      516);
-		if (!NT_STATUS_IS_OK(status)) {
-			return status;
-		}
+	}
+	if (!NT_STATUS_IS_OK(status)) {
+		return status;
 	}
 
 	if (!decode_pw_buffer(p->mem_ctx,