From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 12 Mar 2024 10:51:25 +0000 (+0100)
Subject: s3:libsmb: fix lpcfg_gensec_settings() no memory check in auth_generic_client_prepare()
X-Git-Tag: tdb-1.4.11~792
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2fd2d28b8fea0611bd21862a3eff29633b0c781d;p=thirdparty%2Fsamba.git

s3:libsmb: fix lpcfg_gensec_settings() no memory check in auth_generic_client_prepare()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/libsmb/auth_generic.c b/source3/libsmb/auth_generic.c
index 527b51900d8..b4f283f388a 100644
--- a/source3/libsmb/auth_generic.c
+++ b/source3/libsmb/auth_generic.c
@@ -80,7 +80,7 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
 	}
 
 	gensec_settings = lpcfg_gensec_settings(ans, lp_ctx);
-	if (lp_ctx == NULL) {
+	if (gensec_settings == NULL) {
 		DEBUG(10, ("lpcfg_gensec_settings failed\n"));
 		TALLOC_FREE(ans);
 		return NT_STATUS_NO_MEMORY;