From: Pauli <pauli@openssl.org>
Date: Wed, 23 Jun 2021 04:18:25 +0000 (+1000)
Subject: property: remove spurious incorrect comments
X-Git-Tag: openssl-3.0.0-beta2~225
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2fee3a77f8179c8e4c0e33d622549270b380fa8a;p=thirdparty%2Fopenssl.git

property: remove spurious incorrect comments

Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/15871)
---

diff --git a/crypto/property/property.c b/crypto/property/property.c
index c3f1c5ac587..a4cd612b9da 100644
--- a/crypto/property/property.c
+++ b/crypto/property/property.c
@@ -273,12 +273,7 @@ int ossl_method_store_add(OSSL_METHOD_STORE *store, const OSSL_PROVIDER *prov,
     }
     impl->provider = prov;
 
-    /*
-     * Insert into the hash table if required.
-     *
-     * A write lock is used unconditionally because we wend our way down to the
-     * property string code which isn't locking friendly.
-     */
+    /* Insert into the hash table if required */
     if (!ossl_property_write_lock(store)) {
         OPENSSL_free(impl);
         return 0;
@@ -418,10 +413,7 @@ int ossl_method_store_fetch(OSSL_METHOD_STORE *store, int nid,
     if (nid <= 0 || method == NULL || store == NULL)
         return 0;
 
-    /*
-     * This only needs to be a read lock, because queries never create property
-     * names or value and thus don't modify any of the property string layer.
-     */
+    /* This only needs to be a read lock, because the query won't create anything */
     if (!ossl_property_read_lock(store))
         return 0;
     alg = ossl_method_store_retrieve(store, nid);