From: Guannan Ren <gren@redhat.com>
Date: Wed, 10 Apr 2013 09:38:07 +0000 (+0800)
Subject: conf: fix a memory leak when parsing nat port XML nodes
X-Git-Tag: v1.0.5-rc1~181
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2fff380105b7890fb6a7408b3bc0b6bb8fcf9203;p=thirdparty%2Flibvirt.git

conf: fix a memory leak when parsing nat port XML nodes

 ==5306== 8 bytes in 1 blocks are definitely lost in loss record 24 of 277
 ==5306==    at 0x4C28B2F: calloc (vg_replace_malloc.c:593)
 ==5306==    by 0x5293CAF: virAllocN (viralloc.c:152)
 ==5306==    by 0x52DFEAE: virXPathNodeSet (virxml.c:611)
 ==5306==    by 0x5313DD9: virNetworkDefParseXML (network_conf.c:1408)
 ==5306==    by 0x53170F6: virNetworkObjUpdateParseFile (network_conf.c:2031)
 ==5306==    by 0x131DA63C: networkStartup (bridge_driver.c:279)
 ==5306==    by 0x53481DF: virStateInitialize (libvirt.c:822)
 ==5306==    by 0x40DF44: daemonRunStateInit (libvirtd.c:877)
 ==5306==    by 0x52D2FF5: virThreadHelper (virthreadpthread.c:161)
 ==5306==    by 0x5D00C52: start_thread (in /usr/lib64/libpthread-2.17.so)
 ==5306==    by 0x6410ECC: clone (in /usr/lib64/libc-2.17.so)
---

diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c
index c5535e6539..968cf11eeb 100644
--- a/src/conf/network_conf.c
+++ b/src/conf/network_conf.c
@@ -1440,6 +1440,7 @@ cleanup:
     VIR_FREE(addrStart);
     VIR_FREE(addrEnd);
     VIR_FREE(natAddrNodes);
+    VIR_FREE(natPortNodes);
     ctxt->node = save;
     return ret;
 }