From: bugreport%peshkin.net <>
Date: Wed, 7 Jul 2004 12:10:55 +0000 (+0000)
Subject: Bug 250080: Fix regression causing blank regexp to make all users group members
X-Git-Tag: bugzilla-2.18rc1~22
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=301233f8df92dcb3b84c38ebe707716179e1d419;p=thirdparty%2Fbugzilla.git

Bug 250080: Fix regression causing blank regexp to make all users group members
r=erik, justdave
a=justdave
---

diff --git a/editgroups.cgi b/editgroups.cgi
index 4390b5d446..1b2f0d3df6 100755
--- a/editgroups.cgi
+++ b/editgroups.cgi
@@ -64,7 +64,7 @@ sub RederiveRegexp ($$)
                                 AND grant_type = ? and isbless = 0");
     $sth->execute();
     while (my ($uid, $login) = $sth->fetchrow_array()) {
-        if ($login =~ m/$regexp/i)
+        if (($regexp =~ /\S+/) && ($login =~ m/$regexp/i))
         {
             $sthadd->execute($uid, $gid, GRANT_REGEXP);
         } else {