From: Ondrej Zajicek (work) <santiago@crfreenet.org>
Date: Fri, 15 Dec 2017 23:42:56 +0000 (+0100)
Subject: Netlink: Fix memory leak
X-Git-Tag: v2.0.1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3013fc57bdc97b0031c4f4250b9bdd172f4c0f4e;p=thirdparty%2Fbird.git

Netlink: Fix memory leak
---

diff --git a/sysdep/linux/netlink.c b/sysdep/linux/netlink.c
index 72ff13fa3..4cb515196 100644
--- a/sysdep/linux/netlink.c
+++ b/sysdep/linux/netlink.c
@@ -1666,14 +1666,6 @@ nl_parse_route(struct nl_parse_state *s, struct nlmsghdr *h)
     ra->nh.labels = labels;
 #endif
 
-  rte *e = rte_get_temp(ra);
-  e->net = net;
-  e->u.krt.src = src;
-  e->u.krt.proto = i->rtm_protocol;
-  e->u.krt.seen = 0;
-  e->u.krt.best = 0;
-  e->u.krt.metric = 0;
-
   if (i->rtm_scope != def_scope)
     {
       ea_list *ea = lp_alloc(s->pool, sizeof(ea_list) + sizeof(eattr));
@@ -1687,9 +1679,6 @@ nl_parse_route(struct nl_parse_state *s, struct nlmsghdr *h)
       ea->attrs[0].u.data = i->rtm_scope;
     }
 
-  if (a[RTA_PRIORITY])
-    e->u.krt.metric = rta_get_u32(a[RTA_PRIORITY]);
-
   if (a[RTA_PREFSRC])
     {
       ip_addr ps = rta_get_ipa(a[RTA_PREFSRC]);