From: Ralph Boehme Date: Mon, 31 Jul 2023 13:56:26 +0000 (+0200) Subject: python/provision: avoid SDDL conversion in set_dir_acl() X-Git-Tag: tevent-0.17.0~521 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=301c36d1ad6d81e4983001c607d501bea7551014;p=thirdparty%2Fsamba.git python/provision: avoid SDDL conversion in set_dir_acl() This is not needed and has the potential to loose information if the sddl code wouldn't have all features implemented. No intended change in behaviour. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14927 Pair-Programmed-With: Stefan Metzmacher Signed-off-by: Ralph Boehme Signed-off-by: Stefan Metzmacher --- diff --git a/python/samba/provision/__init__.py b/python/samba/provision/__init__.py index f091ccf2f18..119ff3f49fa 100644 --- a/python/samba/provision/__init__.py +++ b/python/samba/provision/__init__.py @@ -1648,7 +1648,7 @@ def set_gpos_acl(sysvol, dnsdomain, domainsid, domaindn, samdb, lp, use_ntvfs, p acl = ndr_unpack(security.descriptor, policy["nTSecurityDescriptor"][0]).as_sddl() policy_path = getpolicypath(sysvol, dnsdomain, str(policy["cn"])) - set_dir_acl(policy_path, dsacl2fsacl(acl, domainsid), lp, + set_dir_acl(policy_path, dsacl2fsacl(acl, domainsid, as_sddl=False), lp, str(domainsid), use_ntvfs, passdb=passdb)