From: John Ferlan <jferlan@redhat.com>
Date: Fri, 4 Apr 2014 13:55:00 +0000 (-0400)
Subject: NFS storage pool: Fix libvirtd crash due to refactor edit
X-Git-Tag: v1.2.4-rc1~184
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=30283b8640f514e5d05299ad2fee02e792dedac9;p=thirdparty%2Flibvirt.git

NFS storage pool: Fix libvirtd crash due to refactor edit

Commit id '18642d10' refactored the call to virCommandRunRegex()
inside a new function virStorageBackendFileSystemNetFindNFSPoolSources(),
but the cut-n-paste didn't remove the "&state".  Now that state is passed
by reference, it results in a libvirtd core with a messages entry:

"...internal error: unknown storage pool type Unknow"
---

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index 1d85871fb3..4e4a7aee8f 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -266,7 +266,7 @@ virStorageBackendFileSystemNetFindNFSPoolSources(virNetfsDiscoverState *state)
 
     if (virCommandRunRegex(cmd, 1, regexes, vars,
                            virStorageBackendFileSystemNetFindPoolSourcesFunc,
-                           &state, NULL) < 0)
+                           state, NULL) < 0)
         virResetLastError();
 
     virCommandFree(cmd);