From: David Mulder Date: Tue, 8 Nov 2022 18:03:36 +0000 (-0700) Subject: gp: Ignore crontab -l error, since it means empty X-Git-Tag: talloc-2.4.0~565 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3030813765ff2f9ef6c894a4e6eb51601fe07109;p=thirdparty%2Fsamba.git gp: Ignore crontab -l error, since it means empty We should not fail when crontab -l errors, this just means the crontab is empty. Signed-off-by: David Mulder Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Tue Nov 8 22:33:37 UTC 2022 on sn-devel-184 --- diff --git a/python/samba/gp/gp_scripts_ext.py b/python/samba/gp/gp_scripts_ext.py index 3ff650996bb..bbf609cf5d5 100644 --- a/python/samba/gp/gp_scripts_ext.py +++ b/python/samba/gp/gp_scripts_ext.py @@ -20,6 +20,7 @@ from samba.gp.gpclass import gp_pol_ext, drop_privileges from base64 import b64encode from hashlib import blake2b from tempfile import NamedTemporaryFile +from samba.gp.util.logging import log intro = ''' ### autogenerated by samba @@ -98,7 +99,7 @@ def fetch_crontab(username): p = Popen(['crontab', '-l', '-u', username], stdout=PIPE, stderr=PIPE) out, err = p.communicate() if p.returncode != 0: - raise RuntimeError('Failed to read the crontab: %s' % err) + log.warning('Failed to read the crontab: %s' % err) m = re.findall('%s(.*)%s' % (intro, end), out.decode(), re.DOTALL) if len(m) == 1: entries = m[0].strip().split('\n')