From: Nishank Trivedi Date: Thu, 30 Aug 2012 19:27:27 +0000 (-0400) Subject: Fix issue of PF brought down if VF is 8021.Qbh and pci passthrough X-Git-Tag: v0.10.1~17 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3044433f29eacd57f98360e688634b42f1d48d56;p=thirdparty%2Flibvirt.git Fix issue of PF brought down if VF is 8021.Qbh and pci passthrough If a 8021.Qbh network device supports SRIOV and its VF is being used in pci passthrough mode, when the guest is shutdown or destroyed, the PF inteface is also brought down. qemuDomainHostdevNetConfigRestore() finds out the PF for provided hostdev (which is VF) and passes it to virNetDevPortProfileDisassociate() as linkdev. Later, linkdev gets passed to virNetDevSetOnline() where the interface is brought down by clearing IFF_UP flag. Bringing down a PF, when only VF is being brought down is not expected behavior. This patch adds a check so that virNetDevSetOnline() is called only for PF and not if device is a VF. Signed-off-by: Nishank Trivedi --- diff --git a/AUTHORS b/AUTHORS index 3a961c9a4c..58a7303bf2 100644 --- a/AUTHORS +++ b/AUTHORS @@ -261,6 +261,7 @@ Patches have also been contributed by: J.B. Joret Stefan Hajnoczi Gene Czarcinski + Nishank Trivedi [....send patches to get your name here....] diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index 52133782fd..fbbdde91ac 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -1235,7 +1235,8 @@ virNetDevVPortProfileDisassociate(const char *macvtap_ifname, /* avoid disassociating twice */ if (vmOp == VIR_NETDEV_VPORT_PROFILE_OP_MIGRATE_IN_FINISH) break; - ignore_value(virNetDevSetOnline(linkdev, false)); + if (vf < 0) + ignore_value(virNetDevSetOnline(linkdev, false)); rc = virNetDevVPortProfileOp8021Qbh(linkdev, macvtap_macaddr, vf, virtPort, NULL, VIR_NETDEV_VPORT_PROFILE_LINK_OP_DISASSOCIATE);