From: Neil Horman <nhorman@openssl.org>
Date: Thu, 25 Apr 2024 12:46:21 +0000 (-0400)
Subject: Fix coverity 1596617
X-Git-Tag: openssl-3.4.0-alpha1~627
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3059052992ab61b0ba560ddf48111cecb5158ae2;p=thirdparty%2Fopenssl.git

Fix coverity 1596617

Somehow a double free slipped into conf_mod.c, remove it

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <ppzgs1@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24263)
---

diff --git a/crypto/conf/conf_mod.c b/crypto/conf/conf_mod.c
index 23912a56ccb..ccd28a146a7 100644
--- a/crypto/conf/conf_mod.c
+++ b/crypto/conf/conf_mod.c
@@ -368,7 +368,6 @@ static CONF_MODULE *module_add(DSO *dso, const char *name,
 
  err:
     ossl_rcu_write_unlock(module_list_lock);
-    sk_CONF_MODULE_free(new_modules);
     if (tmod != NULL) {
         OPENSSL_free(tmod->name);
         OPENSSL_free(tmod);