From: James Jones <jejones3141@gmail.com>
Date: Sat, 7 May 2022 01:26:16 +0000 (-0500)
Subject: Remove initial FR_TYPE_NULL check from fr_value_box_from_substr() (CID #1504016)... 
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=306070ae8251a2b90ab3bec12798803a4e24d79d;p=thirdparty%2Ffreeradius-server.git

Remove initial FR_TYPE_NULL check from fr_value_box_from_substr() (CID #1504016) (#4496)

Better to let it be handled in the switch statement.
---

diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 4c469f1bffb..ab51b8c9e16 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -4581,8 +4581,6 @@ ssize_t fr_value_box_from_substr(TALLOC_CTX *ctx, fr_value_box_t *dst,
 	char				buffer[256];
 	fr_slen_t			slen;
 
-	if (!fr_cond_assert(dst_type != FR_TYPE_NULL)) return -1;
-
 	if (!rules) rules = &default_rules;
 
 	fr_strerror_clear();