From: Stéphane Graber Date: Wed, 4 Jun 2014 18:05:25 +0000 (-0400) Subject: Try to be more helpful on container startup failure X-Git-Tag: lxc-1.1.0.alpha1~60 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=307ab05d0f0d62dfd3fc6bd965c317e8ca02fb1e;p=thirdparty%2Flxc.git Try to be more helpful on container startup failure This hides some of the confusing "command X failed to receive response" why are usually caused by another more understandable error. On failure to start() from lxc-start, a new error message is displayed, suggesting the user sets logfile and loglevel and if using -d, restarts the container in the foreground instead. Signed-off-by: Stéphane Graber Acked-by: Serge E. Hallyn --- diff --git a/src/lxc/commands.c b/src/lxc/commands.c index b71274c3e..458d41e1f 100644 --- a/src/lxc/commands.c +++ b/src/lxc/commands.c @@ -136,8 +136,8 @@ static int lxc_cmd_rsp_recv(int sock, struct lxc_cmd_rr *cmd) ret = lxc_abstract_unix_recv_fd(sock, &rspfd, rsp, sizeof(*rsp)); if (ret < 0) { - ERROR("command %s failed to receive response", - lxc_cmd_str(cmd->req.cmd)); + WARN("command %s failed to receive response", + lxc_cmd_str(cmd->req.cmd)); return -1; } diff --git a/src/lxc/lxc_start.c b/src/lxc/lxc_start.c index 9b47e8cd1..1d8145fcd 100644 --- a/src/lxc/lxc_start.c +++ b/src/lxc/lxc_start.c @@ -329,8 +329,16 @@ int main(int argc, char *argv[]) c->want_close_all_fds(c, true); err = c->start(c, 0, args) ? 0 : 1; + + if (err) { + ERROR("The container failed to start."); + if (my_args.daemonize) + ERROR("To get more details, run the container in foreground mode."); + ERROR("Additional information can be obtained by setting the " + "--logfile and --log-priority options."); + } + out: lxc_container_put(c); return err; } -