From: Michael Zimmermann <sigmaepsilon92@gmail.com>
Date: Mon, 20 Apr 2026 16:35:31 +0000 (+0200)
Subject: fs/squashfs: Set ret to 0 on successful read
X-Git-Tag: v2026.07-rc1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=30885b01aaa4bcdfa3fee9ca3066d3af563e6688;p=thirdparty%2Fu-boot.git

fs/squashfs: Set ret to 0 on successful read

It might still be a positive number due to the call to sqfs_disk_read.
This only happens when reading a file from an uncompressed squashfs.

I found this by trying to boot using the extlinux bootmethod, where
positive values are treated as errors.

Signed-off-by: Michael Zimmermann <sigmaepsilon92@gmail.com>
Acked-by: Richard Genoud <richard.genoud@bootlin.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---

diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
index 543db8c7e9e..0768fc4a7b2 100644
--- a/fs/squashfs/sqfs.c
+++ b/fs/squashfs/sqfs.c
@@ -1636,6 +1636,8 @@ static int sqfs_read_nest(const char *filename, void *buf, loff_t offset,
 		*actread = finfo.size;
 	}
 
+	ret = 0;
+
 out:
 	free(fragment);
 	free(datablock);