From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Tue, 28 Oct 2025 07:49:13 +0000 (+0100)
Subject: basic: Use xopenat_full() in mkdir_p_root_full()
X-Git-Tag: v259-rc1~235
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=308d40626d9b5d65dbf553c019d8356c6e007eb0;p=thirdparty%2Fsystemd.git

basic: Use xopenat_full() in mkdir_p_root_full()
---

diff --git a/src/basic/mkdir.c b/src/basic/mkdir.c
index a3a02b3e4eb..384b8606114 100644
--- a/src/basic/mkdir.c
+++ b/src/basic/mkdir.c
@@ -237,22 +237,19 @@ int mkdir_p_root_full(const char *root, const char *p, uid_t uid, gid_t gid, mod
         if (r < 0)
                 return r;
 
-        if (path_strv_contains(subvolumes, p))
-                r = btrfs_subvol_make_fallback(dfd, bn, m);
-        else
-                r = RET_NERRNO(mkdirat(dfd, bn, m));
-        if (r == -EEXIST)
+        _cleanup_close_ int nfd = xopenat_full(
+                                dfd, bn,
+                                O_DIRECTORY|O_CREAT|O_EXCL|O_NOFOLLOW|O_CLOEXEC,
+                                path_strv_contains(subvolumes, p) ? XO_SUBVOLUME : 0,
+                                m);
+        if (nfd == -EEXIST)
                 return 0;
-        if (r < 0)
-                return r;
+        if (nfd < 0)
+                return nfd;
 
         if (ts == USEC_INFINITY && !uid_is_valid(uid) && !gid_is_valid(gid))
                 return 1;
 
-        _cleanup_close_ int nfd = openat(dfd, bn, O_CLOEXEC|O_DIRECTORY|O_NOFOLLOW);
-        if (nfd < 0)
-                return -errno;
-
         if (ts != USEC_INFINITY) {
                 struct timespec tspec;
                 timespec_store(&tspec, ts);