From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 4 Aug 2021 09:36:31 +0000 (+0200)
Subject: virNetServerGetClients: Remove pointless cleanup
X-Git-Tag: v7.7.0-rc1~268
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=30b6be3f8cf8ca70ce451b8215b8b6d42544789f;p=thirdparty%2Flibvirt.git

virNetServerGetClients: Remove pointless cleanup

'list' will always be NULL when reaching 'virObjectListFreeCount' thus
we can remove the call as well as the 'ret' variable which was only ever
equal to 'nclients' at the point when we returned the value.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c
index bb1a96b65e..b3214883ee 100644
--- a/src/rpc/virnetserver.c
+++ b/src/rpc/virnetserver.c
@@ -1077,7 +1077,6 @@ int
 virNetServerGetClients(virNetServer *srv,
                        virNetServerClient ***clts)
 {
-    int ret = -1;
     size_t i;
     size_t nclients = 0;
     virNetServerClient **list = NULL;
@@ -1090,11 +1089,10 @@ virNetServerGetClients(virNetServer *srv,
     }
 
     *clts = g_steal_pointer(&list);
-    ret = nclients;
 
-    virObjectListFreeCount(list, nclients);
     virObjectUnlock(srv);
-    return ret;
+
+    return nclients;
 }
 
 virNetServerClient *