From: Martin Schwenke <martin@meltin.net>
Date: Mon, 20 Aug 2018 04:55:17 +0000 (+1000)
Subject: ctdb-tests: Don't run valgrind or other tracing in simple_test_command()
X-Git-Tag: tdb-1.3.17~1889
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=30eb28818d5fbbb35d0965a92f721243aca6ab54;p=thirdparty%2Fsamba.git

ctdb-tests: Don't run valgrind or other tracing in simple_test_command()

This function is used to run a extra command to check a result.  This
command is usually a script (often a stub) or an external command, so
no need to trace it with valgrind or whatever else might be specified.
In the worst case the command being run is a shell function, which
valgrind won't be able to find.

There is little use running the event script tests under valgrind.
However, when the whole test suite is being run under valgrind then it
should work.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Sep  3 14:04:00 CEST 2018 on sn-devel-144
---

diff --git a/ctdb/tests/eventscripts/scripts/local.sh b/ctdb/tests/eventscripts/scripts/local.sh
index 03df06860e9..ad683cf9934 100644
--- a/ctdb/tests/eventscripts/scripts/local.sh
+++ b/ctdb/tests/eventscripts/scripts/local.sh
@@ -547,5 +547,5 @@ simple_test_event ()
 
 simple_test_command ()
 {
-    unit_test "$@"
+    unit_test_notrace "$@"
 }