From: David Mulder <dmulder@suse.com>
Date: Thu, 17 May 2018 22:48:47 +0000 (-0600)
Subject: gpo: Use the new process_group_policy() for unapply
X-Git-Tag: tdb-1.3.17~1409
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=30f6ac9c1632d4e7522576d64c6dff2f205dbf96;p=thirdparty%2Fsamba.git

gpo: Use the new process_group_policy() for unapply

Signed-off-by: David Mulder <dmulder@suse.com>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
---

diff --git a/python/samba/gpclass.py b/python/samba/gpclass.py
index 748411f7aba..0aeeba42362 100644
--- a/python/samba/gpclass.py
+++ b/python/samba/gpclass.py
@@ -507,26 +507,20 @@ def apply_gp(lp, creds, logger, store, gp_extensions):
     store.commit()
 
 
-def unapply_log(gp_db):
-    while True:
-        item = gp_db.apply_log_pop()
-        if item:
-            yield item
-        else:
-            break
-
-
 def unapply_gp(lp, creds, logger, store, gp_extensions):
     gp_db = store.get_gplog(creds.get_username())
     gp_db.state(GPOSTATE.UNAPPLY)
-    for gpo_guid in unapply_log(gp_db):
-        gp_db.set_guid(gpo_guid)
-        unapply_attributes = gp_db.list(gp_extensions)
-        for attr in unapply_attributes:
-            attr_obj = attr[-1](logger, gp_db, lp, attr[0], attr[1])
-            attr_obj.mapper()[attr[0]][0](attr[1])  # Set the old value
-            gp_db.delete(str(attr_obj), attr[0])
-        gp_db.commit()
+    # Treat all applied gpos as deleted
+    del_gpos = gp_db.get_applied_settings(gp_db.get_applied_guids())
+    store.start()
+    for ext in gp_extensions:
+        try:
+            ext.process_group_policy(del_gpos, [])
+        except Exception as e:
+            logger.error('Failed to unapply extension  %s' % str(ext))
+            logger.error('Message was: ' + str(e))
+            continue
+    store.commit()
 
 
 def parse_gpext_conf(smb_conf):