From: Yasuyuki KOZAKAI <yasuyuki@netfilter.org>
Date: Tue, 13 Feb 2007 04:06:45 +0000 (+0000)
Subject: Error if no ICMP type is specified even though user intended
X-Git-Tag: v1.3.8~30
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3122ce9ada8a8acbf3b1035c02618559b21d7ccd;p=thirdparty%2Fiptables.git

Error if no ICMP type is specified even though user intended
to use icmp match.
---

diff --git a/extensions/libipt_icmp.c b/extensions/libipt_icmp.c
index 8f22d052..ce468379 100644
--- a/extensions/libipt_icmp.c
+++ b/extensions/libipt_icmp.c
@@ -284,6 +284,9 @@ static void save(const struct ipt_ip *ip, const struct ipt_entry_match *match)
 /* Final check; we don't care. */
 static void final_check(unsigned int flags)
 {
+	if (!flags)
+		exit_error(PARAMETER_PROBLEM,
+			   "icmp match: You must specify `--icmp-type'");
 }
 
 static struct iptables_match icmp = {