From: Ján Tomko Date: Wed, 9 Sep 2020 08:55:40 +0000 (+0200) Subject: virsh: cmdScreenshot: fix cbdata passing to virshStreamSink X-Git-Tag: v6.8.0-rc1~235 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3144e881b137123b0326157ce6dc23ca649c9270;p=thirdparty%2Flibvirt.git virsh: cmdScreenshot: fix cbdata passing to virshStreamSink The changes for sparse stream support started passing virshStreamCallbackDataPtr to virshStreamSink instead of passing a simple file descriptor, but forgot to adjust all the callers. Fix it in cmdScreenshot as well. https://bugzilla.redhat.com/show_bug.cgi?id=1875195 Signed-off-by: Ján Tomko Fixes: 9e745a97171e10f050962c166082439d6724e245 Reviewed-by: Martin Kletzander --- diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 31597ee469..d1d3f8e566 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5628,6 +5628,7 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) bool generated = false; char *mime = NULL; virshControlPtr priv = ctl->privData; + virshStreamCallbackData cbdata; if (vshCommandOptStringReq(ctl, cmd, "file", (const char **) &file) < 0) return false; @@ -5663,7 +5664,10 @@ cmdScreenshot(vshControl *ctl, const vshCmd *cmd) created = true; } - if (virStreamRecvAll(st, virshStreamSink, &fd) < 0) { + cbdata.ctl = ctl; + cbdata.fd = fd; + + if (virStreamRecvAll(st, virshStreamSink, &cbdata) < 0) { vshError(ctl, _("could not receive data from domain %s"), name); goto cleanup; }