From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Date: Sat, 7 Dec 2019 09:56:00 +0000 (+1300)
Subject: selftest/s4: remove illegal function signature
X-Git-Tag: ldb-2.1.1~200
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=314b59fbeff1fc788a8841c58defd530bd551261;p=thirdparty%2Fsamba.git

selftest/s4: remove illegal function signature

The character ':' has no meaning in function signatures. Perhaps ';' was
intended, which would have marked the later arguments as optional --
which is the default with no signature. All callers always provide all
the arguments anyway.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index e1e3af16e37..3fd70db4570 100755
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -394,7 +394,7 @@ sub get_cmd_env_vars
 # Sets up a forest trust namespace.
 # (Note this is different to kernel namespaces, setup by the
 # USE_NAMESPACES=1 option)
-sub setup_namespaces($$:$$)
+sub setup_namespaces
 {
 	my ($self, $localenv, $upn_array, $spn_array) = @_;