From: Joe Orton <jorton@apache.org>
Date: Thu, 20 Jun 2019 07:27:06 +0000 (+0000)
Subject: Clarify pool lifetime constraints when modifying ap_server_config_defines.
X-Git-Tag: 2.5.0-alpha2-ci-test-only~2025
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=314fb18f15ceb32589e40224257faeac6c8768b2;p=thirdparty%2Fapache%2Fhttpd.git

Clarify pool lifetime constraints when modifying ap_server_config_defines.

PR: 63516


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1861672 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/include/http_main.h b/include/http_main.h
index fa1ce85216d..65f7eb6b682 100644
--- a/include/http_main.h
+++ b/include/http_main.h
@@ -66,8 +66,10 @@ AP_DECLARE_DATA extern apr_array_header_t *ap_server_pre_read_config;
 /** An array of all -c directives.  These are processed after the server's
  *  config file */
 AP_DECLARE_DATA extern apr_array_header_t *ap_server_post_read_config;
-/** An array of all -D defines on the command line.  This allows people to
- *  effect the server based on command line options */
+/** An array of all -D defines on the command line.  This allows users
+ *  to effect the server based on command line options.  A module
+ *  which adds to this array must allocate the new element value from
+ *  same pool as the array (->pool in the array header).  */
 AP_DECLARE_DATA extern apr_array_header_t *ap_server_config_defines;
 /** Available integer for using the -T switch */
 AP_DECLARE_DATA extern int ap_document_root_check;