From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sat, 9 Dec 2017 17:54:28 +0000 (+0100)
Subject: coverity: #1425883
X-Git-Tag: lxc-3.0.0.beta1~113^2~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3151d4e2d8207aa6d0d64b44e5a5921b39a67c43;p=thirdparty%2Flxc.git

coverity: #1425883

ensure \0-termination

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index 934754b6e..de2537247 100644
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -2177,11 +2177,14 @@ static char ** do_lxcapi_get_interfaces(struct lxc_container *c)
 	close(pipefd[1]);
 
 	while (read(pipefd[0], &interface, IFNAMSIZ) == IFNAMSIZ) {
+		interface[IFNAMSIZ - 1] = '\0';
+
 		if (array_contains(&interfaces, interface, count))
 				continue;
 
 		if(!add_to_array(&interfaces, interface, count))
-			ERROR("PARENT: add_to_array failed");
+			ERROR("Failed to add \"%s\" to array", interface);
+
 		count++;
 	}