From: Eric Blake <eblake@redhat.com>
Date: Tue, 2 Aug 2011 15:56:10 +0000 (-0600)
Subject: rpc: avoid uninitialized memory use
X-Git-Tag: v0.9.4~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3157d78f52e27f704058f1f9b19276ea1d47b3cb;p=thirdparty%2Flibvirt.git

rpc: avoid uninitialized memory use

Spotted by Coverity.  Gnutls documents that buffer must be NULL
if gnutls_x509_crt_get_key_purpose_oid is to be used to determine
the correct size needed for allocating a buffer.

* src/rpc/virnettlscontext.c
(virNetTLSContextCheckCertKeyPurpose): Initialize buffer.
---

diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c
index 2a58ede131..be082074cb 100644
--- a/src/rpc/virnettlscontext.c
+++ b/src/rpc/virnettlscontext.c
@@ -264,7 +264,7 @@ static int virNetTLSContextCheckCertKeyPurpose(gnutls_x509_crt_t cert,
     int i;
     unsigned int purposeCritical;
     unsigned int critical;
-    char *buffer;
+    char *buffer = NULL;
     size_t size;
     bool allowClient = false, allowServer = false;